I haven't tried a lot of other MTB shorts for comparison, but I really like these. They fit good, look great, and work well. I like them so much I'm considering buying another pair.
My only complaint is that the snaps on the fly don't stay snapped--they're constantly popping open. (It's not because they're too small on me because my brother has the same shorts and had the same problem.) Fortunately it's pretty easy to fix. Just lay the snaps down on a hard surface (like concrete) and hammer the tops of them lightly until they'll stay snapped together. (If you accidentally overdo it and can't snap them back together use a pair of pliers to squeeze the mushroomed head back in a bit until you can snap them together again.)
I only give them 4 stars because of the snap issue, but otherwise I'd rate them 5 stars.